Adding extra check if def macros are not actually present in the source

.gitea/workflows/build_composer.yaml

@@ -0,0 +1,29 @@
+
+name: Publish PHP Package
+
+on:
+  push:
+    tags:
+      - 'v*'
+
+jobs:
+  docker:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v3
+
+    - name: Get tag name
+      run: echo "TAG=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
+
+    - name: zip and send
+      run: |
+        ls -la
+        apt-get update -y
+        apt-get install -y zip
+        cd ../
+        zip -r ${{ gitea.event.repository.name }}.zip ${{ gitea.event.repository.name }} -x '*.git*'
+        curl -v \
+        --user composer-pbl:${{ secrets.COMPOSER_PSWD }} \
+        --upload-file ${{ gitea.event.repository.name }}.zip \
+        https://git.bit5.ru/api/packages/bit/composer?version=${{ env.TAG }}      

CHANGELOG.md

@@ -0,0 +1,9 @@
+## v1.4.0
+- Disallowing duplicating def macro arguments
+
+## v1.3.3
+- Adding experimental support for prefixing of included macros via <%INC("path/to", "prefix")%>
+
+## v1.2.0
+- JSM now supports an array of base dirs
+- Renaming @builtin into @global for better clarity

composer.json

@@ -6,6 +6,6 @@
         "php": ">=7.4"
     },
     "autoload": {
-        "classmap": ["jsm.inc.php"]
+        "files": ["jsm.inc.php"]
     }
 }

jsm.inc.php

@@ -43,7 +43,7 @@ class JSM
     throw new Exception("Module for '$file' not found");
   }
 
-  function _extractModule($file)
+  function _extractModule($file) : JSM_Module
   {
     $txt = file_get_contents($file);
     if($txt === false)
@@ -54,11 +54,12 @@ class JSM
     $m->node = new JSM_MacroDefNode($file/*using file as name*/);
     $this->_pushCurrentModule($m);
 
-    $txt = $this->_fixJunk($txt);
-    $txt = $this->_removeBlockComments($txt);
-    $txt = $this->_removeLineComments($txt);
+    $txt = self::_fixJunk($txt);
+    $txt = self::_removeBlockComments($txt);
+    $txt = self::_removeLineComments($txt);
     $txt = $this->_processIncludes($file, $txt);
     $txt = $this->_extractScriptDefs($file, $txt);
+
     $this->_parseDefBody($m->node, $file, $txt);
 
     $this->_popCurrentModule();
@@ -79,7 +80,7 @@ class JSM
     return $m;
   }
 
-  function _currentModule()
+  function _currentModule() : JSM_Module 
   {
     $m = end($this->cur_modules);
     if(!$m)
@@ -87,12 +88,13 @@ class JSM
     return $m;
   }
 
-  function getCurrentModule()
+  function getCurrentModule() : JSM_Module
   {
     return $this->_currentModule();
   }
 
-  function process()
+  //NOTE: returns [json, module]
+  function process() : array
   {
     $m = $this->_extractModule($this->file);
 
@@ -102,9 +104,17 @@ class JSM
     $this->defs = $m->defs;
     $this->includes = $m->includes;
 
-    $this->_pushBuffer();
-    $m->node->call($this);
-    $res = $this->_popBuffer();
+    $res = '';
+    if($m->node->raw_text_node) 
+    {
+      $res = $m->node->raw_text_node->txt;
+    }
+    else
+    {
+      $this->_pushBuffer();
+      $m->node->call($this);
+      $res = $this->_popBuffer();
+    }
 
     if($this->buffers)
       throw new Exception("Non closed buffers " . sizeof($this->buffers));
@@ -233,34 +243,37 @@ class JSM
     throw new Exception("Var '$name' not resolved");
   }
 
-  private function _fixJunk($txt)
+  private static function _fixJunk(string $txt) : string
   {
     //windows eol
     $txt = str_replace("\r\n", "\n", $txt);
     return $txt;
   }
 
-  private function _removeBlockComments($txt)
+  private static function _removeBlockComments(string $txt) : string
   {
     if(strpos($txt, '/*') === false)
       return $txt;
-    $regex = '~/\*.*?\*/~s';
     $txt = preg_replace_callback(
-      $regex, 
+      '~/\*.*?\*/~s',
       //preserve the new lines for better error reporting
       function($m) { return str_repeat("\n", substr_count($m[0], "\n")); },
       $txt);
     return $txt;
   }
 
-  private function _removeLineComments($txt)
+  private static function _removeLineComments(string $txt) : string
   {
     //TODO: it's not robust enough, note a hack for URL addresses
-    $txt = preg_replace("~\s*(?<!:)//.*~", "\n", $txt);
+    $txt = preg_replace_callback(
+      '~\s*(?<!:)//.*~', 
+      //preserve the new lines for better error reporting
+      function($m) { return str_repeat("\n", substr_count($m[0], "\n")); },
+      $txt);
     return $txt;
   }
 
-  /*private */function _relpathCallback(array $m, $curr_dir)
+  /*private */function _relpathCallback(array $m, string $curr_dir) : string
   {
     //1) checking if such a file exists and normalizing all .. in the path
     $full_path = realpath($curr_dir . '/' . $m[1]);
@@ -273,7 +286,7 @@ class JSM
     return $rel_path;
   }
 
-  /*private */function _relconfCallback(array $m, $curr_dir)
+  /*private */function _relconfCallback(array $m, string $curr_dir) : string
   {
     //1) checking if such a file exists and normalizing all .. in the path
     $full_path = realpath($curr_dir . '/' . $m[1] . '.conf.js');
@@ -286,7 +299,7 @@ class JSM
     return "@$rel_path";
   }
 
-  private function _processRelpaths($file, $txt)
+  private function _processRelpaths(string $file, string $txt) : string
   {
     //normalizing all file paths
     if(strpos($txt, './') !== false)
@@ -305,7 +318,7 @@ class JSM
     return $txt;
   }
 
-  /*private */function _includesCallback($inc_path, $curr_file)
+  /*private */function _includesCallback(string $inc_path, string $prefix, string $curr_file) : string
   {
     $file = jsm_resolve_inc_path($this->base_dirs, $curr_file, $inc_path);
 
@@ -313,11 +326,11 @@ class JSM
 
     if(!isset(self::$modules[$file]))
     {
-      if($this->_hasExtension($file, '.js'))
+      if(self::_hasExtension($file, '.js'))
       {
         self::$modules[$file] = $this->_extractModule($file);
       }
-      else if($this->_hasExtension($file, '.php'))
+      else if(self::_hasExtension($file, '.php'))
       {
         include_once($file);
         //special mark for PHP include
@@ -337,8 +350,11 @@ class JSM
       {
         foreach($m->includes as $f => $_)
           $cm->includes[$f] = 1;
-        foreach($m->defs as $n => $d)
+
+        foreach($m->defs as $_n => $d)
         {
+          $n = $prefix.$_n;
+
           if(isset($cm->defs[$n]) && $cm->defs[$n] !== $d)
             throw new Exception("Def '$n' is already defined in '{$cm->file}' (check {$cm->defs[$n]->file})");
           $cm->defs[$n] = $d;
@@ -350,42 +366,42 @@ class JSM
     return $need_include_macro ? "<%INC($file)%>" : '';
   }
 
-  private function _processIncludes($file, $txt)
+  private function _processIncludes(string $file, string $txt) : string
   {
     if(strpos($txt, 'INC') !== false)
     {
       $self = $this;
       $txt = preg_replace_callback(
-        '~<%\s*INC\s*\(\s*"([^"]+)"\s*\)\s*%>~', 
-        function($m) use($self, $file) { return $self->_includesCallback($m[1], $file); }, 
+        '~<%\s*INC\s*\(\s*"([^"]+)"\s*(?:,\s*"([^"]+)")?\s*\)\s*%>~', 
+        function($m) use($self, $file) { return $self->_includesCallback($m[1], isset($m[2]) ? $m[2] : '', $file); }, 
         $txt);
     }
     
     return $txt;
   }
 
-  function _isIncluded($file)
+  function _isIncluded(string $file) : bool
   {
     $file = jsm_normalize_path($file);
     return isset($this->includes[$file]);
   }
 
-  function _hasExtension($file, $ext)
+  static function _hasExtension(string $file, string $ext) : bool
   {
     return strpos($file, $ext, strlen($file) - strlen($ext) - 1) !== false;
   }
 
-  static function getDeps(array $base_dirs, $file)
+  static function getDeps(array $base_dirs, string $file) : array
   {
     $deps = array();
     self::_getDeps($base_dirs, $file, $deps);
     return $deps;
   }
 
-  static private function _extractDeps($txt)
+  static private function _extractDeps(string $txt) : array
   {
     $dep_files = array();
-    if(preg_match_all('~<%\s*(?:INC)\s*\(\s*"([^\n]+)~', $txt, $ms))
+    if(preg_match_all('~<%\s*INC\s*\(\s*"([^\n]+)~', $txt, $ms))
     {
       foreach($ms[1] as $raw_dep)
       {
@@ -396,7 +412,7 @@ class JSM
     return array_keys($dep_files);
   }
 
-  static private function _getDeps(array $base_dirs, $file, &$deps)
+  static private function _getDeps(array $base_dirs, string $file, array &$deps)
   {
     static $cache = array();
 
@@ -438,7 +454,7 @@ class JSM
     }  
   }
 
-  private function _extractDefNameAndArgs($full_name)
+  private function _extractDefNameAndArgs(string $full_name) : array
   {
     $pos = strpos($full_name, '(');
     if($pos == -1)
@@ -451,14 +467,14 @@ class JSM
     return array($name, $args);
   }
 
-  private function _parseMacroDefArgs($args_str)
+  private function _parseMacroDefArgs(string $args_str)
   {
     if(!$args_str)
       return array();
     return $this->args_parser->parseDef($args_str);
   }
 
-  function nodes2str($nodes_or_str)
+  function nodes2str($nodes_or_str) : string
   {
     $str = '';
     if(is_array($nodes_or_str))
@@ -475,13 +491,13 @@ class JSM
     return $str;
   }
 
-  function _processMacroArgs($arg_nodes_or_str)
+  function _processMacroArgs($arg_nodes_or_str) : array
   {
     $str = $this->nodes2str($arg_nodes_or_str);
     return $this->_parseMacroArgsStr($str);
   }
 
-  function _parseMacroArgsStr($orig_args_str)
+  function _parseMacroArgsStr($orig_args_str) : array
   {
     static $cache = array();
 
@@ -493,8 +509,8 @@ class JSM
     if($may_cache && isset($cache[$orig_args_str]))
       return $cache[$orig_args_str];
 
-    $args_str = $this->_removeBlockComments($orig_args_str);
-    $args_str = $this->_removeLineComments($args_str);
+    $args_str = self::_removeBlockComments($orig_args_str);
+    $args_str = self::_removeLineComments($args_str);
     $args_str = rtrim($args_str, ',');
 
     $res = $this->args_parser->parseInvoke($args_str);
@@ -505,9 +521,14 @@ class JSM
     return $res;
   }
 
-  private function _extractScriptDefs($file, $txt)
+  private function _extractScriptDefs(string $file, string $txt) : string
   {
-    if(strpos($txt, 'def') === false)
+    $strpos = strpos($txt, 'def');
+    if($strpos === false)
+      return $txt;
+
+    //let's extra check if newline symbols preceed 'def'
+    if($strpos > 0 && !($txt[$strpos-1] === "\n" || $txt[$strpos-1] === "\r"))
       return $txt;
 
     //NOTE: make it more robust
@@ -546,8 +567,11 @@ class JSM
     return $txt;
   }
 
-  private function _replaceVarsWithMacro($file, $txt)
+  private function _replaceVarsWithMacro(string $file, string $txt) : string
   {
+    if(strpos($txt, '$') === false)
+      return $txt;
+
     //simple vals
     $txt = preg_replace(
       '~\{(\$[a-zA-Z0-9_]+)\}~', 
@@ -563,14 +587,16 @@ class JSM
     return $txt;
   }
 
-  private function _parseDefBody(JSM_MacroDefNode $node, $file, $txt)
+  private function _parseDefBody(JSM_MacroDefNode $node, string $file, string $txt)
   {
     $txt = $this->_replaceVarsWithMacro($file, $txt);
 
     //let's exit early if there are no macro calls
     if(strpos($txt, '<%') === false)
     {
-      $node->addChild(new JSM_TextNode($txt));
+      $raw_text_node =  new JSM_TextNode($txt);
+      $node->raw_text_node = $raw_text_node;
+      $node->addChild($raw_text_node);
       return;
     }
 
@@ -626,7 +652,7 @@ class JSM
     $this->_popNode();
   }
 
-  function _newCall($name)
+  function _newCall(string $name)
   {
     $func = "macro_ex_{$name}";
     if(is_callable($func))
@@ -639,7 +665,7 @@ class JSM
     }
   }
 
-  function _getMacro($name)
+  function _getMacro(string $name) : JSM_MacroUserNode
   {
     if(isset($this->defs[$name]))
       return $this->defs[$name];
@@ -683,6 +709,11 @@ interface JSM_MacroNode
   function call(JSM $jsm);
 }
 
+interface JSM_MacroUserNode extends JSM_MacroNode
+{
+  function setUserArgs(array $args);
+}
+
 interface JSM_MacroInternalNode extends JSM_MacroNode
 {
   function addChild(JSM_MacroNode $node);
@@ -742,14 +773,14 @@ class JSM_MacroCallNode implements JSM_MacroInternalNode
   }
 }
 
-class JSM_MacroPHPNode implements JSM_MacroNode
+class JSM_MacroPHPNode implements JSM_MacroUserNode
 {
   var $func;
 
   var $refl;
   var $user_args = '';
 
-  var $is_builtin;
+  var $is_global;
   var $is_eval_args; //arguments will be evaluated and eval result will be passed
   var $is_raw_args;  //arguments result string will be passed, not evaluated
   var $is_node_args; //argument nodes will be passed as is
@@ -764,7 +795,7 @@ class JSM_MacroPHPNode implements JSM_MacroNode
     $this->refl = new ReflectionFunction($php_func);
     $doc = $this->refl->getDocComment();
 
-    $this->is_builtin = strpos($doc, '@builtin') !== false;
+    $this->is_global = strpos($doc, '@global') !== false;
     $this->is_raw_args = strpos($doc, '@raw_args') !== false;
     $this->is_eval_args = strpos($doc, '@eval_args') !== false;
     $this->is_no_args = strpos($doc, '@no_args') !== false;
@@ -785,7 +816,8 @@ class JSM_MacroPHPNode implements JSM_MacroNode
   function call(JSM $jsm)
   {
     //NOTE: making sure file containing PHP macro was actually included by this file
-    if(!$this->is_builtin && !$jsm->_isIncluded($this->refl->getFileName()))
+    //      if it's not a @global one
+    if(!$this->is_global && !$jsm->_isIncluded($this->refl->getFileName()))
       throw new Exception("Macro source file was not included by config file itself: ".$this->refl->getFileName());
 
     $named = false;
@@ -853,13 +885,14 @@ class JSM_MacroPHPNode implements JSM_MacroNode
   }
 }
 
-class JSM_MacroDefNode implements JSM_MacroInternalNode
+class JSM_MacroDefNode implements JSM_MacroInternalNode,JSM_MacroUserNode
 {
   var $name = '';
   var $file = '';
   var $decl_args = array();
   var $node_args = array();
   var $children = array();
+  var $raw_text_node = null;
 
   function __construct($name, $decl_args = array(), $file = '')
   {
@@ -1096,7 +1129,6 @@ class JSM_Eval
     else
     {
       throw new Exception("Unknown func " . $func);
-      return false;
     }
   }
 }
@@ -1318,8 +1350,8 @@ class JSM_Expr
           case ' ': case "\r": case "\t": case "\n" : break;
           case '(': $token = array(self::T_LParen, $c); $binary = false; break;
           case ')': $token = array(self::T_RParen, $c); $binary = true; break;
-          case '+': $token = $this->_getFuncToken(($binary ? '+' : 'u+'), $c); $binary = false; break;
-          case '-': $token = $this->_getFuncToken(($binary ? '-' : 'u-'), $c); $binary = false; break;
+          case '+': $token = $this->_getFuncToken(($binary ? '+' : 'u+')); $binary = false; break;
+          case '-': $token = $this->_getFuncToken(($binary ? '-' : 'u-')); $binary = false; break;
 
           default:
             //try to peek the next symbol and check if such an operator exists
@@ -1374,7 +1406,7 @@ function jsm_lex($string, array $tokenMap)
   {
     foreach($tokenMap as $regex => $token) 
     {
-      if(preg_match($regex, $string, $matches, null, $offset)) 
+      if(preg_match($regex, $string, $matches, 0, $offset)) 
       {
         $tokens[] = array(
           $token,      // token ID      (e.g. T_FIELD_SEPARATOR)
@@ -1562,6 +1594,8 @@ class JSM_ArgsParser
     {
       $this->skip_whitespace();
       $value = $this->parse_arg_value();
+      if(isset($out[$name]))
+        throw new Exception("Argument '{$name}' is already defined in def macro");
       $out[$name] = $value;
       $this->skip_whitespace();
       $ch = $this->next();
@@ -1747,10 +1781,11 @@ class JSM_ArgsParser
         ++$this->c;
     }
 
+    $str_num = substr($this->in, $start, $this->c - $start);
     if($is_float)
-      return 1*substr($this->in, $start, $this->c - $start);
+      return floatval($str_num);
     else
-      return (int)(1*substr($this->in, $start, $this->c - $start));
+      return intval($str_num);
   }
 
   private function _error($error)
@@ -1791,22 +1826,20 @@ class JSM_ArgsParser
 //////////////////////////////////////////////////////
 
 /**
- * @builtin @raw_args
+ * @global @raw_args
  */
-function macro_DEP($jsm)
-{}
-
-/**
- * @builtin @raw_args
- */
-function macro_INC($jsm, $file)
+function macro_INC($jsm, $file_and_prefix)
 {
+  $items = explode(',', $file_and_prefix); 
+  //NOTE: we don't care about prefix here, it's handled 
+  //      during includes processing
+  $file = trim($items[0]);
   $m = $jsm->getModule($file);
   $m->node->call($jsm);
 }
 
 /**
- * @builtin @raw_args
+ * @global @raw_args
  */
 function macro_LET($jsm, $txt_args)
 {
@@ -1816,7 +1849,7 @@ function macro_LET($jsm, $txt_args)
 }
 
 /**
- * @builtin @raw_args
+ * @global @raw_args
  */
 function macro_VAL($jsm, $txt_args)
 {
@@ -1837,7 +1870,7 @@ function macro_VAL($jsm, $txt_args)
 
 //simple version of variable echoing
 /**
- * @builtin @raw_args
+ * @global @raw_args
  */
 function macro_SVAL($jsm, $txt_args)
 {
@@ -1845,7 +1878,7 @@ function macro_SVAL($jsm, $txt_args)
 }
 
 /**
- * @builtin
+ * @global
  */
 function macro_CONST($jsm, $k, $v)
 {
@@ -2038,7 +2071,7 @@ function macro_ex_ENDREP(JSM $jsm)
 }
 
 /**
- * @builtin @raw_args
+ * @global @raw_args
  */
 function macro_CALL($proc, $raw_args)
 {
@@ -2050,7 +2083,7 @@ function macro_CALL($proc, $raw_args)
 }
 
 /**
- * @builtin @eval_args
+ * @global @eval_args
  */
 function macro_TRACE($jsm, array $eval_res)
 {
@@ -2058,7 +2091,7 @@ function macro_TRACE($jsm, array $eval_res)
 }
 
 /**
- * @builtin @raw_args
+ * @global @raw_args
  */
 function macro_LET_IF($jsm, $raw_args)
 {