CHANGELOG.md

@@ -1,5 +0,0 @@
-## v1.8.1
-- Adding null check in need_to_regen_any(..)
-
-## v1.7.2
-- Fixing weird lstat bug on Windows for rrmdir function for large amount of directory items

helpers.inc.php

@@ -87,6 +87,8 @@ function find_files(string $dir, array $fnmatch_patterns = []) : array
   return $results;
 }
 
+
+//obsolete, use find_files instead
 function scan_files_rec(array $dirs, array $only_extensions = [], int $mode = 1) : array
 {
   $files = array();
@@ -166,7 +168,7 @@ function json_make_pretty(string $json) : string
   return prettyJSON($json);
 }
 
-function need_to_regen(string $file, iterable $deps, bool $debug = false) : bool
+function need_to_regen(string $file, array $deps, bool $debug = false) : bool
 {
   if(!is_file($file))
   {
@@ -176,10 +178,9 @@ function need_to_regen(string $file, iterable $deps, bool $debug = false) : bool
   }
 
   $fmtime = filemtime($file); 
-
   foreach($deps as $dep)
   {
-    if($dep && is_file($dep) && (filemtime($dep) > $fmtime))
+    if(is_file($dep) && (filemtime($dep) > $fmtime))
     {
       if($debug)
         echo "$dep > $file\n";
@@ -214,9 +215,6 @@ function need_to_regen_any(array $files, array $deps, bool $debug = false) : boo
     echo "need_to_regen_any, earliest file: $earliest_file ($date)\n";
   }
 
-  if($earliest_file === null)
-    return true;
-
   return need_to_regen($earliest_file, $deps, $debug);
 }
 
@@ -589,7 +587,7 @@ function rrmdir(string $dir, bool $remove_top_dir = true)
     {
       if($object != "." && $object != "..") 
       {
-        if(is_dir($dir."/".$object)) 
+        if(filetype($dir."/".$object) == "dir") 
           rrmdir($dir."/".$object); 
         else 
           unlink($dir."/".$object);
@@ -1193,12 +1191,12 @@ function are_you_sure_ask() : bool
   return $resp == "YES";
 }
 
-function names_hash_changed(string $crc_file, iterable $names) : bool
+function names_hash_changed(string $crc_file, array $names) : bool
 {
   $ctx = hash_init('crc32');
   foreach($names as $name)
     hash_update($ctx, $name);
-  $names_crc = hash_final($ctx, false);
+  $names_crc = hash_final($ctx, true);
   $changed = !file_exists($crc_file) || ensure_read($crc_file) != $names_crc;
   ensure_write($crc_file, $names_crc);
   return $changed;