Gradually migrating to iterable instead of arrays

CHANGELOG.md

@@ -0,0 +1,5 @@
+## v1.8.1
+- Adding null check in need_to_regen_any(..)
+
+## v1.7.2
+- Fixing weird lstat bug on Windows for rrmdir function for large amount of directory items

helpers.inc.php

@@ -87,8 +87,6 @@ function find_files(string $dir, array $fnmatch_patterns = []) : array
   return $results;
 }
 
-
-//obsolete, use find_files instead
 function scan_files_rec(array $dirs, array $only_extensions = [], int $mode = 1) : array
 {
   $files = array();
@@ -168,23 +166,17 @@ function json_make_pretty(string $json) : string
   return prettyJSON($json);
 }
 
-function need_to_regen(string $file, array $deps, bool $debug = false) : bool
+function need_to_regen(string $file, iterable $deps, bool $debug = false) : bool
 {
-  if(is_file($file))
-  {
-    $fmtime = filemtime($file); 
-  }
-  else if(is_dir($file))
-  {
-    $fmtime = filectime($file); 
-  }
-  else
+  if(!is_file($file))
   {
     if($debug)
       echo "! $file\n";
     return true;
   }
 
+  $fmtime = filemtime($file); 
+
   foreach($deps as $dep)
   {
     if($dep && is_file($dep) && (filemtime($dep) > $fmtime))
@@ -222,6 +214,9 @@ function need_to_regen_any(array $files, array $deps, bool $debug = false) : boo
     echo "need_to_regen_any, earliest file: $earliest_file ($date)\n";
   }
 
+  if($earliest_file === null)
+    return true;
+
   return need_to_regen($earliest_file, $deps, $debug);
 }
 
@@ -1198,12 +1193,12 @@ function are_you_sure_ask() : bool
   return $resp == "YES";
 }
 
-function names_hash_changed(string $crc_file, array $names) : bool
+function names_hash_changed(string $crc_file, iterable $names) : bool
 {
   $ctx = hash_init('crc32');
   foreach($names as $name)
     hash_update($ctx, $name);
-  $names_crc = hash_final($ctx, true);
+  $names_crc = hash_final($ctx, false);
   $changed = !file_exists($crc_file) || ensure_read($crc_file) != $names_crc;
   ensure_write($crc_file, $names_crc);
   return $changed;